Consolidate packaging in pyproject.toml
#10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10 +/- ##
==========================================
+ Coverage 91.75% 91.87% +0.11%
==========================================
Files 69 67 -2
Lines 7279 7274 -5
==========================================
+ Hits 6679 6683 +4
+ Misses 600 591 -9 ☔ View full report in Codecov by Sentry. |
ericpre
force-pushed
the
remove_setup.py
branch
from
37b35f2 to
cb76aff
Compare
jlaehne
reviewed
Nov 10, 2023
ericpre
force-pushed
the
remove_setup.py
branch
from
013806b to
54f5871
Compare
ericpre
force-pushed
the
remove_setup.py
branch
from
54230a0 to
242287f
Compare
ericpre
force-pushed
the
remove_setup.py
branch
from
242287f to
165217d
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs hyperspy/hyperspy#3252 to work in editable installation mode (
pip -e). Non-editable pip installation works fine.The motivation for this changes to consolidate package metadata in
pyproject.tomland use modern package building approach, which are now fairly well established.Progress of the PR
pyproject.tomland removesetup.py,